Elgato_dark/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy synced 2026-05-24 09:38:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: no focus border on date cells (#1469)

Browse source 
* fix: no focus border on date cells

* fix: remove redundant import

* refactor: use existing functionality from GridCellWidget for focus border

* refactor: use requestBeginFocus override instead of GestureDetector
This commit is contained in:
Eakam 2022-12-21 06:11:49 -05:00 committed by GitHub
parent 9a387b275f
commit 873a46e443
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_cell.dart
View file

@ -70,17 +70,13 @@ class _DateCellState extends GridCellState<GridDateCell> {
constraints: BoxConstraints.loose(const Size(260, 500)),
margin: EdgeInsets.zero,
child: SizedBox.expand(
child: GestureDetector(
behavior: HitTestBehavior.opaque,
onTap: () => _popover.show(),
child: Align(
alignment: alignment,
child: Padding(
padding: GridSize.cellContentInsets,
child: FlowyText.medium(
state.dateStr,
overflow: TextOverflow.ellipsis,
),
child: Align(
alignment: alignment,
child: Padding(
padding: GridSize.cellContentInsets,
child: FlowyText.medium(
state.dateStr,
overflow: TextOverflow.ellipsis,
),
),
),
@ -108,7 +104,10 @@ class _DateCellState extends GridCellState<GridDateCell> {
}
@override
void requestBeginFocus() {}
void requestBeginFocus() {
_popover.show();
widget.onCellEditing.value = true;
}
@override
String? onCopy() => _cellBloc.state.dateStr;