From a4d1c614ac7ae07e60f0df7913ed4a4d495d618d Mon Sep 17 00:00:00 2001
From: Richard Shiue <71320345+richardshiue@users.noreply.github.com>
Date: Fri, 9 Sep 2022 17:41:09 +0800
Subject: [PATCH 1/2] fix: making selection in grid/kanban sometimes results in
 a create option

---
 .../cell/select_option_editor_bloc.dart       | 21 +++++++------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/frontend/app_flowy/lib/plugins/grid/application/cell/select_option_editor_bloc.dart b/frontend/app_flowy/lib/plugins/grid/application/cell/select_option_editor_bloc.dart
index 03abe5f9c9..cd4ab22ec6 100644
--- a/frontend/app_flowy/lib/plugins/grid/application/cell/select_option_editor_bloc.dart
+++ b/frontend/app_flowy/lib/plugins/grid/application/cell/select_option_editor_bloc.dart
@@ -103,19 +103,11 @@ class SelectOptionCellEditorBloc
   void _filterOption(String optionName, Emitter<SelectOptionEditorState> emit) {
     final _MakeOptionResult result =
         _makeOptions(Some(optionName), state.allOptions);
-    if (optionName.isEmpty) {
-      emit(state.copyWith(
-        filter: Some(optionName),
-        options: result.options,
-        createOption: none(),
-      ));
-    } else {
-      emit(state.copyWith(
-        filter: Some(optionName),
-        options: result.options,
-        createOption: result.createOption,
-      ));
-    }
+    emit(state.copyWith(
+      filter: Some(optionName),
+      options: result.options,
+      createOption: result.createOption,
+    ));
   }
 
   void _loadOptions() {
@@ -155,6 +147,9 @@ class SelectOptionCellEditorBloc
           return name.contains(lFilter);
         });
       }
+      else {
+        createOption = none();
+      }
     });
 
     return _MakeOptionResult(

From 0ef32470768592bd373191152b8955db82eeea0c Mon Sep 17 00:00:00 2001
From: Richard Shiue <71320345+richardshiue@users.noreply.github.com>
Date: Fri, 9 Sep 2022 17:58:06 +0800
Subject: [PATCH 2/2] style: if-else block

---
 .../grid/application/cell/select_option_editor_bloc.dart       | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/frontend/app_flowy/lib/plugins/grid/application/cell/select_option_editor_bloc.dart b/frontend/app_flowy/lib/plugins/grid/application/cell/select_option_editor_bloc.dart
index cd4ab22ec6..93343d8c4c 100644
--- a/frontend/app_flowy/lib/plugins/grid/application/cell/select_option_editor_bloc.dart
+++ b/frontend/app_flowy/lib/plugins/grid/application/cell/select_option_editor_bloc.dart
@@ -146,8 +146,7 @@ class SelectOptionCellEditorBloc
 
           return name.contains(lFilter);
         });
-      }
-      else {
+      } else {
         createOption = none();
       }
     });