From 54a6b863ebbaeaf93d90a76249f9e2171374ecab Mon Sep 17 00:00:00 2001 From: "Lucas.Xu" Date: Fri, 2 Sep 2022 10:32:13 +0800 Subject: [PATCH] chore: fix analysis issue on flutter 3.3.0 --- .../packages/appflowy_editor/lib/src/document/position.dart | 4 +--- .../appflowy_editor/lib/src/document/text_delta.dart | 3 +-- .../appflowy_editor/test/legacy/flowy_editor_test.dart | 5 ++--- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/frontend/app_flowy/packages/appflowy_editor/lib/src/document/position.dart b/frontend/app_flowy/packages/appflowy_editor/lib/src/document/position.dart index a87064d85a..cea065fdea 100644 --- a/frontend/app_flowy/packages/appflowy_editor/lib/src/document/position.dart +++ b/frontend/app_flowy/packages/appflowy_editor/lib/src/document/position.dart @@ -1,5 +1,3 @@ -import 'package:flutter/material.dart'; - import './path.dart'; class Position { @@ -21,7 +19,7 @@ class Position { @override int get hashCode { - final pathHash = hashList(path); + final pathHash = Object.hashAll(path); return Object.hash(pathHash, offset); } diff --git a/frontend/app_flowy/packages/appflowy_editor/lib/src/document/text_delta.dart b/frontend/app_flowy/packages/appflowy_editor/lib/src/document/text_delta.dart index fef58ed08c..3ca877cc98 100644 --- a/frontend/app_flowy/packages/appflowy_editor/lib/src/document/text_delta.dart +++ b/frontend/app_flowy/packages/appflowy_editor/lib/src/document/text_delta.dart @@ -3,7 +3,6 @@ import 'dart:math'; import 'package:appflowy_editor/src/document/attributes.dart'; import 'package:flutter/foundation.dart'; -import 'package:flutter/material.dart'; // constant number: 2^53 - 1 const int _maxInt = 9007199254740991; @@ -462,7 +461,7 @@ class Delta extends Iterable { @override int get hashCode { - return hashList(_operations); + return Object.hashAll(_operations); } /// Returned an inverted delta that has the opposite effect of against a base document delta. diff --git a/frontend/app_flowy/packages/appflowy_editor/test/legacy/flowy_editor_test.dart b/frontend/app_flowy/packages/appflowy_editor/test/legacy/flowy_editor_test.dart index ab37cfec0c..df586b3ac0 100644 --- a/frontend/app_flowy/packages/appflowy_editor/test/legacy/flowy_editor_test.dart +++ b/frontend/app_flowy/packages/appflowy_editor/test/legacy/flowy_editor_test.dart @@ -1,7 +1,6 @@ import 'package:appflowy_editor/src/document/path.dart'; import 'package:appflowy_editor/src/document/position.dart'; import 'package:appflowy_editor/src/document/selection.dart'; -import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; void main() { @@ -75,7 +74,7 @@ void main() { final path2 = [1]; expect(pathEquals(path1, path2), true); - expect(hashList(path1), hashList(path2)); + expect(Object.hashAll(path1), Object.hashAll(path2)); }); test('test path utils 2', () { @@ -83,7 +82,7 @@ void main() { final path2 = [2]; expect(pathEquals(path1, path2), false); - expect(hashList(path1) != hashList(path2), true); + expect(Object.hashAll(path1) != Object.hashAll(path2), true); }); test('test position comparator', () {